zero-sized files in tarballs do not call end handler

[mattgodbolt]

If you are extracting an archive with zero-sized files in it, then the stream your entry handler is passed has already been end-ed. This means the on('end') event is not triggered.

Our code looks something like:

extract.on('entry', async (header, stream, next) => {
  //...
    const filestream = fs.createWriteStream(filepath);
    stream
        .on('error', error => {
            logger.error(`Error in stream handling: ${error}`);
            reject(error);
        })
        .on('end', () => {
            next();  /// <--- this handler is never called for zero-sized files, hanging the stream forever
        })
        .pipe(filestream);
    stream.resume();
    if (header.size === 0) next(); //// <--- adding this line "fixes" the issue

[mattgodbolt]

The stream for empty files is created here:

tar-stream/extract.js

Line 174 in ca0e270

self.emit('entry', header, emptyStream(self, offset), onunlock)

and the stream has already been ended here:

tar-stream/extract.js

Line 12 in ca0e270

const emptyStream = function (self, offset) {

so there's no end() event that's emitted after we have had a change to register an on end handler (as best I can tell).

[mafintosh]

Fixed in 3.1.0