Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed torrent when done #66

Open
BastienClement opened this issue Jun 9, 2014 · 2 comments
Open

Seed torrent when done #66

BastienClement opened this issue Jun 9, 2014 · 2 comments

Comments

@BastienClement
Copy link
Collaborator

Once a torrent is fully downloaded, torrent-stream should switch into a seed-mode until destroyed in order to be a better swarm citizen.

mafintosh/peerflix/issues/58
popcorn-official/popcorn-app/issues/80
asapach/peerflix-server/issues/6

It will still be stoppable once pause/resume functionnality is implemented #49.

@asapach
Copy link
Collaborator

asapach commented Jun 9, 2014

In my experience it depends on the health of the torrent: when there are few seeders, t-s seeds just fine even after completing the download.
The issue is probably caused by the fact that peerflix and peerflix-server don't listen for incoming connections and as the result peers can't break through. This raises the NAT issues like port mapping, nat-upnp and nat-pmp.

@BastienClement
Copy link
Collaborator Author

I opened this issue after reading (from @mafintosh in the peerflix repo)

Yeah - it's probably torrent-stream has a choke timeout that is triggered since we do not wan't any more data. torrent-stream then disconnects the peer. It probably shouldn't do this when it is seeding.

I agree however that low-seeded torrent keep uploading when completed.

This is maybe only a misconception due to well-seeded torrents + engine.swarm.pause() + NAT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants