Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to continue seeding even after download completes #58

Open
hackergrrl opened this issue Apr 19, 2014 · 3 comments
Open

Comments

@hackergrrl
Copy link

I noticed that peerflix ceases uploading to peers once my download finishes. I'd really like to continue seeding while I watch my downloaded video; could this be an option or -- dare I ask -- a default?

@mafintosh
Copy link
Owner

I would have no problem with this being the default. I'm pretty sure it stops seeding because of this, https://github.com/mafintosh/peerflix/blob/master/app.js#L86-L92. Would you be interested in doing a PR?

@hackergrrl
Copy link
Author

I tried removing the code that stopped the engine on uninterested, but the only difference it made was that peerflix would keep on connecting to and then disconnecting peers once I finished downloading. Perhaps there's something deeper, in torrent-stream, that's keeping it from seeding?

@mafintosh
Copy link
Owner

Yeah - it's probably torrent-stream has a choke timeout that is triggered since we do not wan't any more data. torrent-stream then disconnects the peer. It probably shouldn't do this when it is seeding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants