Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo for react-router and backbone-react-component #68

Merged
merged 1 commit into from Apr 17, 2015
Merged

Demo for react-router and backbone-react-component #68

merged 1 commit into from Apr 17, 2015

Conversation

ieugen
Copy link
Contributor

@ieugen ieugen commented Mar 27, 2015

This is also an example on how to use React Router, React and Backbone React Component.

It would be nice to have it merged.

@magalhas
Copy link
Owner

Sweet. I'll take a look during the weekend 👍 Thank you

@ieugen
Copy link
Contributor Author

ieugen commented Mar 27, 2015

As I've said, React has some life cycle methods that we can leverage to bind/unbind Backbone React Component (BRC). The mixin cold do this automatically, but it would be nice to use BRC without mixin, by means of life cycel methods.

@ieugen ieugen closed this Mar 27, 2015
@magalhas
Copy link
Owner

@ieugen why have you closed this issue? Regarding the non mixin method, it's a must for ES6 classes #67

@ieugen ieugen reopened this Mar 27, 2015
@ieugen
Copy link
Contributor Author

ieugen commented Mar 27, 2015

Sorry, my "big fingers" slipped.

@magalhas
Copy link
Owner

magalhas commented Apr 2, 2015

@ieugen does the bug reported in #65 occur in here or should I change the routes to make it happen ? As far as I can tell the routes in the example are query free, no?

@ieugen
Copy link
Contributor Author

ieugen commented Apr 2, 2015

Run the app with broccoli serve. The links send query params. Override
method is not taken into account on query change.

Joi, 2 apr. 2015, 04:54, José Magalhães notifications@github.com a scris:

@ieugen https://github.com/ieugen does the bug reported in #65
#65 occur in
here or should I change the routes to make it happen ? As far as I can tell
the routes in the example are query free, no?


Reply to this email directly or view it on GitHub
#68 (comment)
.

@magalhas
Copy link
Owner

magalhas commented Apr 2, 2015

Probably we're missing one lifecycle hook 👍

@ieugen
Copy link
Contributor Author

ieugen commented Apr 2, 2015

Yes, my thought exactly. By the way, have you given a thought on bindings
without the use of a mixin?

2015-04-02 18:15 GMT+03:00 José Magalhães notifications@github.com:

Probably we're missing one lifecycle hook [image: 👍]


Reply to this email directly or view it on GitHub
#68 (comment)
.

Ioan Eugen Stan
0720 898 747

@magalhas
Copy link
Owner

magalhas commented Apr 2, 2015

@ieugen yes I'll link you on the other issue when I make a comment with my thoughts so that you can contribute with your ideas.

magalhas added a commit that referenced this pull request Apr 17, 2015
Demo for react-router and backbone-react-component
@magalhas magalhas merged commit 2e034fe into magalhas:master Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants