Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tooltip Explaining Size Abbreviations #2558

Closed
AlexGilleran opened this issue Oct 28, 2019 · 0 comments · Fixed by #2573
Closed

Add Tooltip Explaining Size Abbreviations #2558

AlexGilleran opened this issue Oct 28, 2019 · 0 comments · Fixed by #2573
Assignees
Labels
refined Issues that have been refined, reviewed, estimated and are ready to work on

Comments

@AlexGilleran
Copy link
Contributor

AlexGilleran commented Oct 28, 2019

Description

Currently for files that are drag-dropped onto the Add Dataset flow, we display size as KiB/MiB etc - this is more precise (see https://www.majordifferences.com/2018/03/differences-between-megabyte-and.html), but to the uninitiated looks like a typo. We should add a help tip that explains this.

Technical Notes

There are already existing tips - they look like (!) - in the UI. We should just reuse whatever we've done for them in this task. If there's not already a reusable component for these we should create one.

Acceptance Criteria

  • Every potential instance of MiB / KiB / etc has a tooltip nearby that explains the megabyte / mebibyte difference.

Updated: on 1st Nov

  • the tooltip should be a mouseover one
  • We only need to update add dataset page. Don't need to worry about Admin-ui for this ticket
@AlexGilleran AlexGilleran added the refined-unreviewed Issues that have been refined by one person but not been reviewed by the rest of the team label Oct 28, 2019
@AlexGilleran AlexGilleran added this to the Unrefined Backlog milestone Oct 28, 2019
@MelanieHotchkiss MelanieHotchkiss added refined Issues that have been refined, reviewed, estimated and are ready to work on and removed refined-unreviewed Issues that have been refined by one person but not been reviewed by the rest of the team labels Oct 29, 2019
@MelanieHotchkiss MelanieHotchkiss modified the milestones: Unrefined Backlog, Refined Backlog Oct 29, 2019
@sajidanower23 sajidanower23 mentioned this issue Nov 4, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refined Issues that have been refined, reviewed, estimated and are ready to work on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants