Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue caused search Panel option filter stop working #1843

Merged
merged 2 commits into from Nov 9, 2018

Conversation

t83714
Copy link
Contributor

@t83714 t83714 commented Nov 8, 2018

What this PR does

Fixes #1838

Fixed an issue caused search Panel option filter stop working.

Details see #1838

Checklist

  • unit tests aren't applicable
  • I've updated CHANGES.md with what I changed.
  • I've linked this PR to an issue in ZenHub (core dev team only)

@AlexGilleran
Copy link
Contributor

Tacked on some extra code because I couldn't test this with UI-only 😬

Copy link
Contributor Author

@t83714 t83714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good job on fixing the web server pod~
It's now can be deployed as Preview UI Only~ 🎉
Github doesn't allow me to approve my own PR.
@AlexGilleran You can merge it once my part changes are reviewed OK~

@AlexGilleran AlexGilleran merged commit 9d02d53 into master Nov 9, 2018
@AlexGilleran AlexGilleran deleted the issue/1838 branch November 9, 2018 05:18
@magdabot magdabot restored the issue/1838 branch October 7, 2020 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants