[dy] Add ingress chart #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Scheduler Selector labels | ||
| */}} | ||
| {{- define "mageai.schedulerSelectorLabels" -}} | ||
| app.kubernetes.io/name: {{ .Values.scheduler.name }} |
There was a problem hiding this comment.
can you remove unused configs in the ingress helm chart?
Make sure the values used in this file are shown in the values.yaml
charts/ingress/Chart.yaml
Outdated
| annotations: | ||
| artifacthub.io/alternativeName: Mage-Ingress | ||
| artifacthub.io/category: integration-delivery | ||
| artifacthub.io/images: | |
There was a problem hiding this comment.
these images are not used in this helm chart. so you don't need to include them
There was a problem hiding this comment.
|
@wangxiaoyou1993 updated |
wangxiaoyou1993
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create separate helm chart to create ingress for Mage. Including the ingress with the main helm chart can lead to issues when upgrading the chart. I also added a comment to the main helm chart to recommend creating the ingress separately.
Tests
Tested locally
cc: @wangxiaoyou1993