-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service is always running on 6789 (cannot be changed) #54
service is always running on 6789 (cannot be changed) #54
Conversation
@wangxiaoyou1993, could you please support? |
Currently, mageai chart If you needed, Must manually refactor helm templates as shown below. BackgroundIn my opinion, helm-charts/charts/mageai/values.yaml Lines 89 to 93 in 2638ec6
Environment
Workaround
# mageai/values.yaml
service:
type: NodePort
port: 80
+ containerPort: 6789
# Annotations to add to the service
annotations: {}
# mageai/templates/webservice.yaml
containers:
- name: {{ .Chart.Name }}
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
- name: http
- containerPort: {{ .Values.service.port }}
+ containerPort: {{ .Values.service.containerPort | default 6789 }}
protocol: TCP
# running `mageai-webserver` pod's spec
ports:
- containerPort: 6789
name: http
protocol: TCP
readinessProbe:
failureThreshold: 3
httpGet:
path: /api/status
port: http
scheme: HTTP
|
Thank you for your input :) |
@mummyhen Yes, You're right. In my opinion, But in terms of clarity in the chart, I believe it would be better to declare the It is also related to flexibility. By declaring the port in the @wangxiaoyou1993 Could you please review this PR? |
Summary
When updating the port of the load balancer the container port also gets updated but it is not possible to have mageai run on a different port than 6789.
Tests
Deployed the helm chart and tested the connection from the Load Balancer
cc: