Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jk] Dropdown formatting for Windows #1965

Merged
merged 5 commits into from
Feb 23, 2023
Merged

[jk] Dropdown formatting for Windows #1965

merged 5 commits into from
Feb 23, 2023

Conversation

johnson-mage
Copy link
Member

@johnson-mage johnson-mage commented Feb 9, 2023 •
edited

Summary

  • The coloring was off for the Frequency dropdown menu on the Trigger edit page for Windows users. The dropdown items had white font against a white background after an item was selected and the dropdown reopened (the items were visible initially when no item was selected). This PR fixes the coloring for Select dropdowns on Windows.

Tests

Before (dropdown items not visible):
dropdown single

After:
dropdown 1
dropdown 2

@johnson-mage johnson-mage self-assigned this Feb 9, 2023
@johnson-mage johnson-mage force-pushed the jk--dropdown_formatting_windows branch 2 times, most recently from 2f3fac0 to 1558c17 Compare February 23, 2023 17:20
@johnson-mage johnson-mage merged commit 72ecf32 into master Feb 23, 2023
@johnson-mage johnson-mage deleted the jk--dropdown_formatting_windows branch February 23, 2023 22:27
@johnson-mage johnson-mage mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@johnson-mage johnson-mage

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@johnson-mage