-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduler trigger interval as environment variable setting #3591
Scheduler trigger interval as environment variable setting #3591
Conversation
… Removed default value of trigger_interval from TimeTrigger
@wangxiaoyou1993 I've been looking at the classes LoopTimeTrigger and TimeTrigger and I have some light concerns. Should the trigger_interval property be held in the TimeTrigger class? How things work currently is that LoopTimeTrigger does the waiting and TimeTrigger triggers the scheduler; going by that logic, the trigger_interval property should be a property of the entity that does the actual waiting: LoopTimeTrigger. Expandig from this, what are the advantages of having LoopTimeTrigger and TimeTrigger be 2 separate classes? TimeTrigger is only used with the loop part attached so maybe a good solution would be to merge these two? Let me know what you guys think! |
class LoopTimeTrigger inherits the class TimeTrigger. It's just one way to implement the time trigger. It's just to make it extensible if we want to add another implementation for TimeTrigger in the future. |
Description
Added a new setting called SCHEDULER_TRIGGER_INTERVAL that sets the LoopTimeTrigger's sleep time between scheduler calls. Value is of type float. Default value is kept at 10 seconds.
Example call:
How Has This Been Tested?
Set the SCHEDULER_TRIGGER_INTERVAL to some numerical value (default value is 10 seconds).
Checklist
cc:
@adelcast
@hugabora