[dy] Add always on schedule interval #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return True | ||
| else: | ||
| return self.last_pipeline_run_status not in [ | ||
| PipelineRun.PipelineRunStatus.RUNNING, |
There was a problem hiding this comment.
@dy46 Let's include the CANCELLED status here
There was a problem hiding this comment.
@wangxiaoyou1993 if we add cancelled here, there won't be a way for the user to restart their always on trigger after cancelling a run
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User request.
Add
@always_onschedule interval for scheduled triggers. Always on schedules will trigger the new pipeline run as soon as the latest pipeline run is completed. Basically, it should always have 1 pipeline run in progress at all times.I also replaced schedule interval strings with constants in this PR.
How Has This Been Tested?
Checklist
cc: