Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dy] Handle secret key and uuid whitespace #3621

Merged
merged 2 commits into from
Sep 28, 2023
Merged

[dy] Handle secret key and uuid whitespace #3621

merged 2 commits into from
Sep 28, 2023

Conversation

dy46
Copy link
Contributor

@dy46 dy46 commented Sep 28, 2023

Description

In case there is extra whitespace in the key or uuid files for some reason, we should be able to still retrieve the secrets.

How Has This Been Tested?

  • Tested locally
  • Unit test

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:

@dy46 dy46 added the bug Something isn't working label Sep 28, 2023
@dy46 dy46 merged commit 10fe242 into master Sep 28, 2023
11 checks passed
@dy46 dy46 deleted the dy--handle_secret_uuid_whitespace branch September 28, 2023 23:12
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Oct 3, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dy46