Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jk] Pipelines list fixes #3648

Merged
merged 4 commits into from
Oct 3, 2023
Merged

[jk] Pipelines list fixes #3648

merged 4 commits into from
Oct 3, 2023

Conversation

johnson-mage
Copy link
Member

@johnson-mage johnson-mage commented Oct 3, 2023

Description

  • Remove the pipeline statuses retry and retry_incomplete_block_runs from the pipeline filters.
  • Fix ordering of sorted pipeline rows when applying filters.
  • Fix cutoff pipeline context menu.

How Has This Been Tested?

Before (pipeline groupings were sometimes incorrect):
image

After (fixed pipeline groupings):
image

Reposition context menu at bottom of page:
image

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@johnson-mage johnson-mage added the bug Something isn't working label Oct 3, 2023
@johnson-mage johnson-mage self-assigned this Oct 3, 2023
@johnson-mage johnson-mage merged commit 094373c into master Oct 3, 2023
11 checks passed
@johnson-mage johnson-mage deleted the jk--pipelines_list_fixes branch October 3, 2023 05:55
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Oct 3, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant