Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dy] Share main project logging config with workspaces #4656

Merged
merged 3 commits into from
Mar 5, 2024
Merged

[dy] Share main project logging config with workspaces #4656

merged 3 commits into from
Mar 5, 2024

Conversation

dy46
Copy link
Contributor

@dy46 dy46 commented Feb 26, 2024

Description

Add config for main projects workspace_initial_metadata that will be passed to newly created workspaces. This also required adding a INITIAL_METADATA environment variable that will be read while initializing the project.

How Has This Been Tested?

  • Tested with local kubernetes cluster
  • Tested setting INITIAL_METADATA environment variable for new project

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc: @wangxiaoyou1993

@dy46 dy46 added the enhancement Polish or UX improvements label Feb 26, 2024
@dy46 dy46 linked an issue Feb 26, 2024 that may be closed by this pull request
Share main project logging_config with workspaces. #4531
Closed
@dy46 dy46 merged commit 3da2a63 into master Mar 5, 2024
9 checks passed
@dy46 dy46 deleted the 4531-share-main-project-logging_config-with-workspaces branch March 5, 2024 21:21
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Mar 13, 2024
Merged
15 tasks
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
@dy46 @oonyoontong
[dy] Share main project logging config with workspaces (mage-ai#4656)
7856365 
* [dy] Initial commit

* [dy] Update

* [dy] Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangxiaoyou1993 wangxiaoyou1993 Awaiting requested review from wangxiaoyou1993

Assignees
No one assigned
Labels
enhancement Polish or UX improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Share main project logging_config with workspaces.
1 participant
@dy46