[dy] Support reading authentication settings from AWS secrets manager #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -300,6 +304,13 @@ def set_project_uuid_from_metadata() -> None: | |||
| project_uuid = config.get('project_uuid') | |||
|
|
|||
|
|
|||
| def update_settings_on_metadata_change() -> None: | |||
| global project_uuid | |||
There was a problem hiding this comment.
where is the project_uuid used?
mage_ai/settings/backends.py
Outdated
| except ClientError as error: | ||
| if error.response['Error']['Code'] == 'ResourceNotFoundException': | ||
| return None | ||
| raise |
There was a problem hiding this comment.
what are other possible errors? do we not fall back to env variables for those errors?
There was a problem hiding this comment.
good point. i'll log an error and return None
| self.client = boto3.client('secretsmanager') | ||
| self.prefix = kwargs.get('prefix', '') | ||
|
|
||
| def _get(self, key: str, **kwargs) -> Optional[str]: |
There was a problem hiding this comment.
can we also allow user to configure whether to use AWS secret cache?
There was a problem hiding this comment.
good idea, i'll add that
dy46
force-pushed
the
4598-storing-git-secrets-in-aws-secrets-manager-instead-of-environment-variables
branch
from
e4050e9
to
438fdf5
Compare
dy46
changed the title
|
@wangxiaoyou1993 PTAL |
dy46
force-pushed
the
4598-storing-git-secrets-in-aws-secrets-manager-instead-of-environment-variables
branch
from
438fdf5
to
ececb04
Compare
|
Have you tested with all those different authentication methods? |
|
can you also update the doc? |
wangxiaoyou1993
approved these changes
Mar 8, 2024
dy46
force-pushed
the
4598-storing-git-secrets-in-aws-secrets-manager-instead-of-environment-variables
branch
from
b170fd7
to
eb338ad
Compare
dy46
deleted the
4598-storing-git-secrets-in-aws-secrets-manager-instead-of-environment-variables
branch
15 tasks
oonyoontong
pushed a commit
to bunker-tech/mage-ai
that referenced
this pull request
May 2, 2024
…mage-ai#4674) * [dy] Update settings * [dy] Update * [dy] Update again * [dy] Update once more * [dy] Fix test * [dy] Fix session test * [dy] Fix session test again * [dy] Fix test * [dy] Fix test 2 * [dy] Address comments * [dy] Update * [dy] Rebase * [dy] Update comments * [dy] Update docs * [dy] Move all git settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for reading settings from AWS secrets manager. Only some of the existing settings have been moved to using the new
Settingsclass. Most server settings that are not secrets are still being directly read from environment variables.In order to set the settings backend, the user will need to add a section to the project metadata. Here is an example to set the setting backend to AWS secrets manager:
This PR also adds an observer to the project metadata file so that if there are any updates to that file, the settings backend can be updated.
How Has This Been Tested?
Checklist
docs/mint.jsoncc: