Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dy] Add try/except #4683

Merged
merged 1 commit into from
Mar 4, 2024
Merged

[dy] Add try/except #4683

merged 1 commit into from
Mar 4, 2024

Conversation

dy46
Copy link
Contributor

@dy46 dy46 commented Feb 29, 2024

Description

Try .fillna('') for every column and catch the exception if it fails. This should resolve the most critical issue for now.

How Has This Been Tested?

  • Tested locally with bug reproduction steps in the issue.

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc: @wangxiaoyou1993

@dy46 dy46 added the bug Something isn't working label Feb 29, 2024
@dy46 dy46 linked an issue Feb 29, 2024 that may be closed by this pull request
@dy46 dy46 merged commit f37e584 into master Mar 4, 2024
9 checks passed
@dy46 dy46 deleted the 4616-integer-reading-and-display-issue branch March 4, 2024 18:33
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Mar 13, 2024
15 tasks
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integer reading and display issue
2 participants