Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jk] Fix "filter is not a function" type error in schema props #4686

Merged
merged 3 commits into from
Feb 29, 2024
Merged

[jk] Fix "filter is not a function" type error in schema props #4686

merged 3 commits into from
Feb 29, 2024

Conversation

johnson-mage
Copy link
Member

Description

  • Fixes this issue: There was an error (screenshot below) causing the app to crash when user was viewing the "Schema properties" of a data stream for an integration block in a standard pipeline. This was due to an unexpected column type (a non-array value received).
image

How Has This Been Tested?

  • Tested locally. Was able to recreate error and confirmed it no longer appeared.

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

@johnson-mage johnson-mage added the bug Something isn't working label Feb 29, 2024
@johnson-mage johnson-mage self-assigned this Feb 29, 2024
@johnson-mage johnson-mage merged commit f7189aa into master Feb 29, 2024
9 checks passed
@johnson-mage johnson-mage deleted the jk--bugfix-integration_block_schema_props branch February 29, 2024 22:25
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Mar 13, 2024
Merged
15 tasks
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
@johnson-mage @oonyoontong
[jk] Fix "filter is not a function" type error in schema props (mage-…
06eb1d4 
…ai#4686)

* [jk] Fix "filter is not a function" type error

* [jk] Default types to empty array when adding type

* [jk] Default types to empty array when removing type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@johnson-mage johnson-mage

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@johnson-mage