[dy] Add error stack trace to the message for pipeline run failure #4697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -312,7 +320,14 @@ def schedule(self, block_runs: List[BlockRun] = None) -> None: | |||
| failed_block_runs = self.pipeline_run.failed_block_runs | |||
| error_msg = 'Failed blocks: '\ | |||
| f'{", ".join([b.block_uuid for b in failed_block_runs])}.' | |||
|
|
|||
| error = None | |||
There was a problem hiding this comment.
can we reduce duplicate code?
dy46
force-pushed
the
4653-add-error-stack-trace-when-sending-out-failure-alert-notification
branch
from
425f1a2
to
e94866c
Compare
wangxiaoyou1993
approved these changes
Mar 6, 2024
dy46
deleted the
4653-add-error-stack-trace-when-sending-out-failure-alert-notification
branch
15 tasks
oonyoontong
pushed a commit
to bunker-tech/mage-ai
that referenced
this pull request
May 2, 2024
…age-ai#4697) * [dy] Initial commit * [dy] Add error stacktrace to the pipeline run failure message * [dy] Add error stacktrace to the pipeline run failure message * [dy] Fix tests * [dy] Consolidate * [dy] Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add error details to the message. I only add the latest error message if there are multiple errors because there could potentially be a lot of blocks that error.
How Has This Been Tested?
Checklist
docs/mint.jsoncc: @wangxiaoyou1993