Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xy] Add auto clean name flag to io classes. #4698

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

wangxiaoyou1993
Copy link
Member

@wangxiaoyou1993 wangxiaoyou1993 commented Mar 2, 2024

Description

Add auto clean name flag to io classes so that user has the option to not clean the column names. The default value is True.

Close: #4602

This can be achieved by including auto_clean_name=False param in the export method.

How Has This Been Tested?

  • Tested with MSSQL, Postgres and MySQL blocks
image

Data inserted
image

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc:

@wangxiaoyou1993 wangxiaoyou1993 added the enhancement Polish or UX improvements label Mar 2, 2024
@wangxiaoyou1993 wangxiaoyou1993 merged commit a073744 into master Mar 4, 2024
9 checks passed
@wangxiaoyou1993 wangxiaoyou1993 deleted the xiaoyou/auto-clean-name-flag branch March 4, 2024 07:37
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Mar 13, 2024
15 tasks
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
* [xy] Add auto clean name flag to io classes.

* [xy] Pass auto_clean_name arg to table creation method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Polish or UX improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Allow reserved words" option to mssql
1 participant