Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dy] Fix logging for elasticsearch destination #4709

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

dy46
Copy link
Contributor

@dy46 dy46 commented Mar 5, 2024

Description

.warning doesn't exist on the mage_integrations logger, so changing it to .info.

How Has This Been Tested?

  • Tested locally

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc:

@dy46 dy46 added the bug Something isn't working label Mar 5, 2024
@dy46 dy46 merged commit 3e004ce into master Mar 5, 2024
9 checks passed
@dy46 dy46 deleted the dy--fix_elasticsearch_logger branch March 5, 2024 22:09
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Mar 13, 2024
15 tasks
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant