Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xy] Set repo_path when syncing trigger configs. #4719

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

wangxiaoyou1993
Copy link
Member

@wangxiaoyou1993 wangxiaoyou1993 commented Mar 7, 2024

Description

Set repo_path when syncing trigger configs so that triggers.yaml of the same pipeline in multi-dev environment don't affect each other.

How Has This Been Tested?

  • Tested with triggers.yaml in a pipeline. Before the fix, there's no repo_path associated with the PipelineSchedule. After the fix, the repo_path is added the PipelineSchedule db models.
image

tested it in multiple project platform as well (note: the trigger name needs to be different in different project)

  • before fix
    image
  • after fix
    image

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc:

@wangxiaoyou1993 wangxiaoyou1993 added the bug Something isn't working label Mar 7, 2024
@wangxiaoyou1993 wangxiaoyou1993 merged commit bef59a7 into master Mar 7, 2024
9 checks passed
@wangxiaoyou1993 wangxiaoyou1993 deleted the xiaoyou/sync-triggers-with-repo-path branch March 7, 2024 23:59
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Mar 13, 2024
15 tasks
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant