Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jk] Delete backfills #4726

Merged
merged 6 commits into from
Mar 8, 2024
Merged

[jk] Delete backfills #4726

merged 6 commits into from
Mar 8, 2024

Conversation

johnson-mage
Copy link
Member

Description

  • Add delete button to backfills table that allows user to delete backfills individually.
  • Prevent user from setting a backfill interval unit value less than 1, which could cause issues loading the backfills.

How Has This Been Tested?

delete backfill

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

@johnson-mage johnson-mage added the feature New feature or request label Mar 8, 2024
@johnson-mage johnson-mage self-assigned this Mar 8, 2024
@johnson-mage johnson-mage merged commit 018a4d7 into master Mar 8, 2024
9 checks passed
@johnson-mage johnson-mage deleted the jk--delete_backfills branch March 8, 2024 19:29
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Mar 13, 2024
Merged
15 tasks
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
@johnson-mage @oonyoontong
[jk] Delete backfills (mage-ai#4726)
c1b34cc 
* [jk] Remove custom as interval type option

* [jk] Set minimum backfill interval unit value to 1

* [jk] Update empty runs message when backfill's trigger is deleted

* [jk] Update docs

* [jk] Add delete button to backfills table

* [jk] Add minimum value to Max concurrent runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@johnson-mage johnson-mage

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@johnson-mage