Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jk] Allow file to be opened in Pipeline Editor without Command Center enabled #4728

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

johnson-mage
Copy link
Member

@johnson-mage johnson-mage commented Mar 9, 2024

Description

  • In the Pipeline Editor, users weren't able to open a file by clicking on it in the File Browser, which should open it in an Arcane Library popup window. This PR fixes this.

How Has This Been Tested?

Before (file wont open until you enable Command Center):
before - cant open file in pipeline editor

After (file does open even before enabling Command Center):
after - files can be opened

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

@johnson-mage johnson-mage added the bug Something isn't working label Mar 9, 2024
@johnson-mage johnson-mage self-assigned this Mar 9, 2024
@johnson-mage johnson-mage merged commit f7505b5 into master Mar 9, 2024
9 checks passed
@johnson-mage johnson-mage deleted the jk--bugfix-open_file_window branch March 9, 2024 04:32
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Mar 13, 2024
15 tasks
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant