Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jk] Bugfix dock overlay #4733

Merged
merged 3 commits into from
Mar 11, 2024
Merged

[jk] Bugfix dock overlay #4733

merged 3 commits into from
Mar 11, 2024

Conversation

johnson-mage
Copy link
Member

Description

  • The bottom 20px of a page was unclickable (e.g. horizontal scrollbars at the page bottom could not be clicked on) due to the height of the hidden dock used for managing applications causing a z-index issue. This PR decreases the dock height so bottom elements can be interacted with.
  • Also fix some spacing and scrollbar issues in the Sidekick on the Pipeline Editor page.

How Has This Been Tested?

Bottom horizontal scrollbars can be clicked (previously, could not interact with them):
horizontal scroll

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

@johnson-mage johnson-mage added the bug Something isn't working label Mar 11, 2024
@johnson-mage johnson-mage self-assigned this Mar 11, 2024
@johnson-mage johnson-mage merged commit 01c922d into master Mar 11, 2024
9 checks passed
@johnson-mage johnson-mage deleted the jk--bugfix-dock_overlay branch March 11, 2024 21:27
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Mar 13, 2024
Merged
15 tasks
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
@johnson-mage @oonyoontong
[jk] Bugfix dock overlay (mage-ai#4733)
e7c3dba 
* [jk] Fix spacing and scrollbars in Sidekick

* [jk] Fix linting

* [jk] Decrease height of dock so bottom portion of page can be clicked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@johnson-mage johnson-mage

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@johnson-mage