Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[edw] e2e: ensure example pipeline runs smoothly #4771

Merged
merged 4 commits into from
Apr 2, 2024
Merged

[edw] e2e: ensure example pipeline runs smoothly #4771

merged 4 commits into from
Apr 2, 2024

Conversation

edmondwinston
Copy link
Contributor

@edmondwinston edmondwinston commented Mar 16, 2024 •
edited by johnson-mage

Description

This PR creates e2e test which runs the default_repo's example_pipeline once to ensure pipelines could run smoothly.

How Has This Been Tested?

  • Tests pass on github.

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc: @johnson-mage

@johnson-mage johnson-mage self-requested a review March 18, 2024 17:05
@johnson-mage johnson-mage added the testing Add tests (e.g. Playwright tests on FE, BE unit tests, etc) label Mar 18, 2024
johnson-mage
johnson-mage approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@johnson-mage johnson-mage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, made some minor changes like language updates. Thank you @edmondwinston!

@johnson-mage johnson-mage merged commit 047ce2f into mage-ai:master Apr 2, 2024
4 checks passed
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Apr 11, 2024
Merged
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
@edmondwinston @johnson-mage @oonyoontong
[edw] e2e: ensure example pipeline runs smoothly (mage-ai#4771)
ca9812d 
* [edw]: add working test

* [edw]: add comments

* [jk] Update test

* [jk] Remove check

---------

Co-authored-by: Johnson Kwok <johnson@mage.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnson-mage johnson-mage johnson-mage approved these changes

Assignees

@edmondwinston edmondwinston

Labels
testing Add tests (e.g. Playwright tests on FE, BE unit tests, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edmondwinston @johnson-mage