Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xy] Interpolate global vars in k8s executor namespace #4792

Merged
merged 2 commits into from Mar 19, 2024

Conversation

wangxiaoyou1993
Copy link
Member

Description

Close: #4488

Support dynamic namespace in k8s executor by interpolating vars in the namespace
https://docs.mage.ai/development/variables/overview

How Has This Been Tested?

  • Tested with local kubernetes cluster

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc:

@wangxiaoyou1993 wangxiaoyou1993 added the enhancement Polish or UX improvements label Mar 19, 2024
@wangxiaoyou1993 wangxiaoyou1993 merged commit 75c6f84 into master Mar 19, 2024
9 checks passed
@wangxiaoyou1993 wangxiaoyou1993 deleted the xiaoyou/dynamic-k8s-namespace2 branch March 19, 2024 22:58
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Mar 27, 2024
15 tasks
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
* [xy] Interpolate global vars in k8s executor namespace

* [xy] Fix var interpolation in k8s pipeline executor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Polish or UX improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dynamic namespace configuration ability in each pipeline run for K8s Executor
1 participant