Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jk] Bugfixes - table render / rename destination block #4797

Merged
merged 3 commits into from Mar 20, 2024
Merged

[jk] Bugfixes - table render / rename destination block #4797

merged 3 commits into from Mar 20, 2024

Conversation

johnson-mage
Copy link
Member

@johnson-mage johnson-mage commented Mar 20, 2024 •
edited

Description

  • Prevent table rendering error when columns and rows undefined.
  • Fix error (DestinationBlock.update() got an unexpected kwarg 'detach') when trying to rename a destination block in an integration pipeline.
  • Include block pipelines in data integration pipeline destination block (previously wasn't included, which was causing the "Renaming this block will affect X pipelines. The renamed block may need to be re-added to the shared pipeline(s)." warning to not appear when renaming the destination block specifically).

How Has This Been Tested?

  • Tested locally and confirmed errors no longer appear
image

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc:

@johnson-mage johnson-mage added the bug Something isn't working label Mar 20, 2024
@johnson-mage johnson-mage self-assigned this Mar 20, 2024
@johnson-mage johnson-mage changed the title Jk bugfix rename integration block [jk] Bugfixes - table render, rename destination block, missing destination block rename warning Mar 20, 2024
@johnson-mage johnson-mage changed the title [jk] Bugfixes - table render, rename destination block, missing destination block rename warning [jk] Bugfixes - table render / rename destination block Mar 20, 2024
@johnson-mage johnson-mage merged commit cd45092 into master Mar 20, 2024
9 checks passed
@johnson-mage johnson-mage deleted the jk--bugfix-rename_integration_block branch March 20, 2024 20:25
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Mar 27, 2024
Merged
15 tasks
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
@johnson-mage @oonyoontong
[jk] Bugfixes - table render / rename destination block (mage-ai#4797)
86ef955 
* [jk] Prevent table render error

* [jk] Fix integration pipeline data exporter rename error

* [jk] Include block pipelines in integration destination block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@johnson-mage johnson-mage

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@johnson-mage