Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dy] Catch JSON decode errors in mage targets #4838

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[dy] Catch JSON decode errors in mage targets #4838

merged 1 commit into from
Mar 28, 2024

Conversation

dy46
Copy link
Contributor

@dy46 dy46 commented Mar 26, 2024

Description

Some targets did not properly catch JSON parsing issues, so updating those targets to handle that.

How Has This Been Tested?

  • Tested locally

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc:

@dy46 dy46 added the bug Something isn't working label Mar 26, 2024
@dy46 dy46 linked an issue Mar 26, 2024 that may be closed by this pull request
[BUG] Data integration from API breaks #4773
Closed
@dy46 dy46 merged commit 4c4fff9 into master Mar 28, 2024
9 checks passed
@dy46 dy46 deleted the 4773-bug-data-integration-from-api-breaks branch March 28, 2024 19:22
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Apr 11, 2024
Merged
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
@dy46 @oonyoontong
[dy] Catch JSON decode errors in mage targets (mage-ai#4838)
e80516d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Data integration from API breaks
1 participant
@dy46