Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jk] Replace blue font with cyan in terminal #4848

Merged
merged 7 commits into from
Mar 28, 2024
Merged

[jk] Replace blue font with cyan in terminal #4848

merged 7 commits into from
Mar 28, 2024

Conversation

johnson-mage
Copy link
Member

@johnson-mage johnson-mage commented Mar 28, 2024 •
edited

Description

  • The blue font in the terminal was hard to read, so this PR replaces the blue font with the more legible cyan font.
  • Limit the terminal output in the UI to 2500 lines. Including more starts to hurt app performance, at least in development mode (e.g. typing in the terminal becomes very laggy to the point of being basically unusable).

How Has This Been Tested?

  • Tested locally

Before (the "notice" text has blue font):
image

After (the "notice" text has cyan font):
image

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc:

@johnson-mage johnson-mage added the enhancement Polish or UX improvements label Mar 28, 2024
@johnson-mage johnson-mage self-assigned this Mar 28, 2024
@johnson-mage johnson-mage merged commit d7f1293 into master Mar 28, 2024
9 checks passed
@johnson-mage johnson-mage deleted the jk--replace_terminal_blue_font branch March 28, 2024 23:36
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Apr 11, 2024
Merged
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
@johnson-mage @oonyoontong
[jk] Replace blue font with cyan in terminal (mage-ai#4848)
9f31dc9 
* [jk] Replace blue font with cyan in terminal

* [jk] Default data to string

* [jk] Replace all instances of blue text within a string

* [jk] Limit terminal output

* [jk] Decrease terminal output to improve performance further

* [jk] Increase historical output

* [jk] Limit terminal output for stdout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@johnson-mage johnson-mage

Labels
enhancement Polish or UX improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@johnson-mage