Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jk] Fix filters from being reset when items fetched #4859

Merged
merged 2 commits into from
Mar 30, 2024

Conversation

johnson-mage
Copy link
Member

Description

  • The filters toggles on the /pipeline-runs and /pipelines/[pipeline_uuid]/triggers were being reset unexpectedly due to the filter component getting re-rendered with stale data every time a certain resource was being fetched. This PR fixes this issue.

How Has This Been Tested?

  • Tested locally

Before (filters periodically reset):
Before - filters periodically reset

After (filter state persists):
After - filters not reset

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc:

@johnson-mage johnson-mage added the bug Something isn't working label Mar 30, 2024
@johnson-mage johnson-mage self-assigned this Mar 30, 2024
@johnson-mage johnson-mage merged commit 0e151ce into master Mar 30, 2024
9 checks passed
@johnson-mage johnson-mage deleted the jk--bugfix-pipeline_runs_filter branch March 30, 2024 02:09
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
* [jk] Fix filters from being reset when items fetched

* [jk] Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant