Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xy] Update snowflake destination datetime to use TIMESTAMP type. #4875

Merged
merged 1 commit into from
Apr 2, 2024
Merged

[xy] Update snowflake destination datetime to use TIMESTAMP type. #4875

merged 1 commit into from
Apr 2, 2024

Conversation

wangxiaoyou1993
Copy link
Member

Description

Close: #4821

How Has This Been Tested?

  • Tested locally with Snowflake destination and datetime type

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc:

@wangxiaoyou1993 wangxiaoyou1993 added the enhancement Polish or UX improvements label Apr 2, 2024
@wangxiaoyou1993 wangxiaoyou1993 merged commit 5d129f6 into master Apr 2, 2024
9 checks passed
@wangxiaoyou1993 wangxiaoyou1993 deleted the xiaoyou/snowflake-dt-type branch April 2, 2024 21:36
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Apr 11, 2024
Merged
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
@wangxiaoyou1993 @oonyoontong
[xy] Update snowflake destination datetime to use TIMESTAMP type. (ma…
aaf0b90 
…ge-ai#4875)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Polish or UX improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Snowflake destination incorrect timezone information on UTC dates
1 participant
@wangxiaoyou1993