Caching pipeline_project outside of loop to avoid multple lookups #4887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scheduler checks in a loop whether a block is an integration block. This instantiates Project object in each call which is quite slow and adds considerably, esp. when many blocks are in the pipeline.
The change caches the pipeline project outside of the loop. The method now takes the cached object as an optional parameter and avoids lookups.
How Has This Been Tested?
Tested in my local project.
Checklist
cc:
@wangxiaoyou1993