Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xy] Support alerts and limited retries in streaming pipeline. #4902

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

wangxiaoyou1993
Copy link
Member

@wangxiaoyou1993 wangxiaoyou1993 commented Apr 8, 2024

Description

Support alerts and limited retries in streaming pipeline.
Close: #4840
Close: #4842

When retry_config is set in streaming pipeline's metadata.yaml at pipeline level, only retry the streaming pipeline with limited times and send alerts when pipeline fails.

How Has This Been Tested?

  • Tested with streaming pipeline with error locally

retry config
image

retry logs
image

alerts
image

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:

@wangxiaoyou1993 wangxiaoyou1993 added the enhancement Polish or UX improvements label Apr 8, 2024
@wangxiaoyou1993 wangxiaoyou1993 merged commit 1a45213 into master Apr 8, 2024
9 checks passed
@wangxiaoyou1993 wangxiaoyou1993 deleted the xiaoyou/streaming-alerts branch April 8, 2024 23:43
@sujiplr
Copy link
Contributor

sujiplr commented Apr 9, 2024

Awesome

oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
…ai#4902)

* [xy] Support alerts and limited retries in streaming pipeline.

* [xy] Retry in the outer loop.

* [xy] Support sending alerts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Polish or UX improvements
Projects
None yet
2 participants