Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xy] Catch pipeline error in scheduler. #4911

Merged
merged 2 commits into from
Apr 9, 2024
Merged

[xy] Catch pipeline error in scheduler. #4911

merged 2 commits into from
Apr 9, 2024

Conversation

wangxiaoyou1993
Copy link
Member

@wangxiaoyou1993 wangxiaoyou1993 commented Apr 9, 2024 •
edited

Description

Currently, if one pipeline's metadata.yaml is invalid, the whole scheduler gets crashed.
Catch pipeline error in scheduler to avoid scheduler crash.

How Has This Been Tested?

  • Tested locally by manually updating a pipeline's metadata.yaml to be invalid
image

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:

@wangxiaoyou1993 wangxiaoyou1993 added the bug Something isn't working label Apr 9, 2024
@wangxiaoyou1993 wangxiaoyou1993 merged commit f2e0cb9 into master Apr 9, 2024
9 checks passed
@wangxiaoyou1993 wangxiaoyou1993 deleted the xiaoyou/catch-scheduler-error branch April 9, 2024 18:55
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Apr 11, 2024
Merged
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
@wangxiaoyou1993 @oonyoontong
[xy] Catch pipeline error in scheduler. (mage-ai#4911)
383503c 
* [xy] Catch pipeline error in scheduler.

* [xy] Catch error of fetching pipeline in pipeline_runs endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@wangxiaoyou1993