Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jk] Prevent renamed triggers in code from being duplicated #4929

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

johnson-mage
Copy link
Member

Description

  • Renamed triggers saved in code (i.e. saved in triggers.yaml file) would update the pipeline schedule in the db, but not the trigger in the trigger config file, resulting in the original trigger being recreated. This PR fixes this so the trigger saved in code is not duplicated.
  • Addresses github issue [BUG] Triggers duplicating after renaming #4862

How Has This Been Tested?

renamed trigger in code 2

renamed trigger in code 1

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:

@johnson-mage johnson-mage added the bug Something isn't working label Apr 12, 2024
@johnson-mage johnson-mage self-assigned this Apr 12, 2024
@johnson-mage johnson-mage requested a review from dy46 April 12, 2024 03:20
@johnson-mage johnson-mage merged commit edc5adb into master Apr 12, 2024
9 checks passed
@johnson-mage johnson-mage deleted the jk--avoid_duplicating_renamed_trigger branch April 12, 2024 19:38
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants