Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dy] Update oauth token column type #4933

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

dy46
Copy link
Contributor

@dy46 dy46 commented Apr 12, 2024

Description

This PR updates the token and refresh_token fields from sa.String(255) to sa.Text(). In some rare cases, the oauth token can be longer than 255 characters, so we need to change the column type to be able to store the entire oauth token.

How Has This Been Tested?

  • Tested migrations with SQLite and PostgreSQL databases
  • Tested that AzureDevOps authentication works with PostgreSQL

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc: @wangxiaoyou1993

@dy46 dy46 force-pushed the dy--fix_azure_devops_oauth_token branch from faecd9a to 009df04 Compare April 16, 2024 17:42
@dy46 dy46 merged commit 067ec91 into master Apr 16, 2024
9 checks passed
@dy46 dy46 deleted the dy--fix_azure_devops_oauth_token branch April 16, 2024 20:22
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
* [dy] Update column type

* [dy] Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants