Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jk] Triggers table UI fixes #4934

Merged
merged 6 commits into from
Apr 13, 2024
Merged

[jk] Triggers table UI fixes #4934

merged 6 commits into from
Apr 13, 2024

Conversation

johnson-mage
Copy link
Member

@johnson-mage johnson-mage commented Apr 13, 2024 •
edited

Description

  • Improve Triggers table column order.
  • Fix Description column widths for very long descriptions.
  • Fix typo for "Sort runs by" text on project-wide Triggers page (these are triggers, not runs).
  • Change "N/A" to a simple "-" in Latest status column for improved differentiation from status text.
  • Show spinner on project-wide Triggers page when pipeline schedules are loading (table previously showed "No triggers available" text when pipeline schedules were loading).

How Has This Been Tested?

  • Confirmed fixes locally

Old Triggers table column order:
image

Updated Triggers table column order:
image

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:

@johnson-mage johnson-mage added the enhancement Polish or UX improvements label Apr 13, 2024
@johnson-mage johnson-mage self-assigned this Apr 13, 2024
@johnson-mage johnson-mage merged commit 458dd08 into master Apr 13, 2024
9 checks passed
@johnson-mage johnson-mage deleted the jk--triggers_table_ui_fixes branch April 13, 2024 03:30
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Apr 26, 2024
Merged
1 task
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
@johnson-mage @oonyoontong
[jk] Triggers table UI fixes (mage-ai#4934)
1f325e0 
* [jk] Set max width on trigger description column

* [jk] Replace N/A with dash

* [jk] Update description width

* [jk] Show spinner when loading project-wide triggers

* [jk] Fix typo

* [jk] Reorder Triggers table columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@johnson-mage johnson-mage

Labels
enhancement Polish or UX improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@johnson-mage