Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xy] Support interpolating trigger name in k8s job name. #4947

Merged
merged 2 commits into from
Apr 16, 2024
Merged

[xy] Support interpolating trigger name in k8s job name. #4947

merged 2 commits into from
Apr 16, 2024

Conversation

wangxiaoyou1993
Copy link
Member

@wangxiaoyou1993 wangxiaoyou1993 commented Apr 16, 2024 •
edited

Description

Support interpolating trigger name in k8s job name by using {trigger_name} in the k8s executor config's job_name_prefix field.

Close: #4910

How Has This Been Tested?

  • Tested with local k8s job
image image

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:

@wangxiaoyou1993 wangxiaoyou1993 added the enhancement Polish or UX improvements label Apr 16, 2024
@wangxiaoyou1993 wangxiaoyou1993 merged commit da00280 into master Apr 16, 2024
8 of 9 checks passed
@wangxiaoyou1993 wangxiaoyou1993 deleted the xiaoyou/custom-trigger-job-name branch April 16, 2024 21:33
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Apr 26, 2024
Merged
1 task
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
@wangxiaoyou1993 @oonyoontong
[xy] Support interpolating trigger name in k8s job name. (mage-ai#4947)
f459ffb 
* [xy] Support interpolating trigger name in k8s job name.

* [xy] Fix name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Polish or UX improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trigger name in job pods
1 participant
@wangxiaoyou1993