Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dy] Remove git dependency #4959

Merged
merged 6 commits into from
Apr 19, 2024
Merged

[dy] Remove git dependency #4959

merged 6 commits into from
Apr 19, 2024

Conversation

dy46
Copy link
Contributor

@dy46 dy46 commented Apr 18, 2024

Description

This PR removes the git dependency for starting Mage. I also added another github workflow to ensure that the webserver can start on windows without git installed. I wanted to run the scheduler as well, but that doesn't seem to work properly which can be resolved in the future.

How Has This Been Tested?

  • CI

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:

@dy46 dy46 force-pushed the dy--remove_git_dependency_2 branch 16 times, most recently from 3c7ee0a to ea4ef0d Compare April 18, 2024 21:23
@dy46 dy46 force-pushed the dy--remove_git_dependency_2 branch from ea4ef0d to a6a13d4 Compare April 18, 2024 21:34
@dy46 dy46 force-pushed the dy--remove_git_dependency_2 branch 3 times, most recently from 79eb6cc to 86eea8f Compare April 18, 2024 23:34
@dy46 dy46 force-pushed the dy--remove_git_dependency_2 branch from 86eea8f to 0ec9cee Compare April 18, 2024 23:50
@dy46 dy46 changed the title [WIP] remove git dependency [dy] Remove git dependency Apr 18, 2024
@dy46 dy46 added the bug Something isn't working label Apr 18, 2024
@dy46 dy46 merged commit 3bd05d0 into master Apr 19, 2024
6 checks passed
@dy46 dy46 deleted the dy--remove_git_dependency_2 branch April 19, 2024 16:48
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
* [dy] Remove git dependencies

* [dy] Test windows

* [dy] Add another job

* [dy] Revert test changes

* [dy] Update tests

* [dy] Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant