Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xy] Fix logging tags for streaming pipeline run. #4963

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

wangxiaoyou1993
Copy link
Member

Description

Fix logging tags for streaming pipeline run. Include pipeline_run_id in the tags so that the logs can show in the pipeline run logs page.

How Has This Been Tested?

  • Tested with local streaming pipeline in k8s cluster
image

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:

@wangxiaoyou1993 wangxiaoyou1993 added the bug Something isn't working label Apr 19, 2024
@wangxiaoyou1993 wangxiaoyou1993 merged commit 1c57f5b into master Apr 19, 2024
9 checks passed
@wangxiaoyou1993 wangxiaoyou1993 deleted the xiaoyou/fix-streaming-pipeline-logging branch April 19, 2024 05:50
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant