[Enhancement] Optionally Disable Wait Timeout in ECS Config #4970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommydangerous
approved these changes
Apr 22, 2024
1 task
oonyoontong
pushed a commit
to bunker-tech/mage-ai
that referenced
this pull request
May 2, 2024
…4970) * add disable wait timeout check * update documentation * formatting --------- Co-authored-by: Moses <mail@moseswynn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ECS executor configs have a setting
wait_timeoutthat tells the executor how long to wait for the task to complete before retrying. Themage_ai.services.aws.ecs.run_taskfunction has been updated to check if this value is set to -1. If so, it will skip waiting for the task to complete.How Has This Been Tested?
There was no test coverage for wait functionality to update for this change. Existing tests for ECS config remain unaffected.
Checklist
cc: