Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dy] Fix some git bugs #4973

Merged
merged 2 commits into from
Apr 23, 2024
Merged

[dy] Fix some git bugs #4973

merged 2 commits into from
Apr 23, 2024

Conversation

dy46
Copy link
Contributor

@dy46 dy46 commented Apr 22, 2024

Description

The git branch related API endpoints were not encoding the branch name, so if the branch name contained a / character, the request would fail. This PR encodes all the branch names before making the API requests. Also, it will fetch remote branches in the GitActions view so that a user can switch to a remote branch in that view.

How Has This Been Tested?

  • Tested locally with GitLab repo in version control and git actions view

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:

@dy46 dy46 linked an issue Apr 22, 2024 that may be closed by this pull request
@dy46 dy46 merged commit caec2cc into master Apr 23, 2024
11 checks passed
@dy46 dy46 deleted the 4936-bug-version-control-branches branch April 23, 2024 21:41
oonyoontong pushed a commit to bunker-tech/mage-ai that referenced this pull request May 2, 2024
* [dy] Fix git

* [dy] Fix git 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Version Control branches
1 participant