[jk] Cancel unsaved modified file dialogue #4975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
oonyoontong
pushed a commit
to bunker-tech/mage-ai
that referenced
this pull request
May 2, 2024
* [jk] Fix hidden tooltip * [jk] Do not close unsaved file with changes when canceling dialogue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cancelin the confirmation dialogue for closing an unsaved, modified file in the File Editor, user would expect the unsaved file to remain open so they could save it, but the file was closing instead, causing unsaved changes to be lost. This PR fixes this so that clickingCancelbehaves as expected.How Has This Been Tested?
Before (clicking cancel closes the file without allowing user to save changes):
After (clicking cancel keeps the file open as expected):
Checklist