fix: pass correct repo url for nightly #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The amendMatrixForNext function uses the repository argument to determine the version constraint for the returned matrix for kind nightly. Previously the upstream-mirror repo url was passed as an argument, but the nightly builds use a different repo url. This resulted in failed builds, because the version string 'next' could not be parsed by composer. Example: https://github.com/mage-os/generate-mirror-repo-js/actions/runs/6370219504/job/17291152703 With this change, the nightly kind will always return the `@alpha` version constraint, that is, stability constraint. There currently is no way to distinguish between different nightly repos, but since both work the same way, this is fine (for now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
amendMatrixForNextfunction uses the repository argument to determine the version constraint for the returned matrix for kind nightly.Previously, the upstream-mirror repo url was passed as an argument, but the nightly builds use a different repo url.
This resulted in failed builds, because the version string 'next' could not be parsed by composer.
Example:
https://github.com/mage-os/generate-mirror-repo-js/actions/runs/6370219504/job/17291152703
What is the new behavior?
With this change, the nightly kind will always return the
@alphaversion constraint, that is, stability constraint. There currently is no way to distinguish between different nightly repos, but since both work the same way, this is fine (for now).Does this PR introduce a breaking change?