Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster 1 requirement is a nuisance #4

Closed
ronkorving opened this issue May 9, 2017 · 1 comment
Closed

Cluster 1 requirement is a nuisance #4

ronkorving opened this issue May 9, 2017 · 1 comment

Comments

@ronkorving
Copy link
Member

We all want installation and usage to be as easy as possible, and I think it would be great if people didn't have to configure their MAGE application specifically for "npm run develop" to function.

  • It's possible that sometimes they'll boot up the app with, and sometimes without the console, and that should not require two separate config files.
  • What happens when I forget to configure my app appropriately, or I'm on the wrong NODE_ENV? How scared should I be for things to go wrong? Not having to worry is a good thing.

Hypothetical solutions:

  • Allow mage-console to work with >1 worker, and have it gracefully shutdown if cluster is false (something we may want to remove support for in a future MAGE version anyway).
  • Let mage-console override application config to set cluster to 1. It's quite possible there's no reliable way to do this today, but maybe we need to work on a way to make this possible.
@ronkorving ronkorving changed the title Cluster 1 requirement is nuisance Cluster 1 requirement is a nuisance May 9, 2017
@stelcheck
Copy link
Member

The proper solution would be to have mage-console auto-configure MAGE, but that's just not possible from what I can tell: mage/mage#67

For now, the way things works is the safest way I can think of; besides, you could always create an environments.yml config and use an environment variable in-project to get the job done (I do this on some of my projects to force-disable certain things during unit tests). However, this just cannot be done from a module.

stelcheck added a commit to stelcheck/mage-console that referenced this issue Nov 26, 2017
Fixes multiple outstanding issues, and pretifies error output by:

  1. using pretty-error to render the error
  2. stripping part of the stack that really should have no relevance

Fixes mage#4 mage#5 mage#8 mage#9 mage#11
stelcheck added a commit to stelcheck/mage-console that referenced this issue Nov 26, 2017
Fixes multiple outstanding issues, and pretifies error output by:

  1. using pretty-error to render the error
  2. stripping part of the stack that really should have no relevance

Fixes mage#4 mage#5 mage#8 mage#9 mage#11
stelcheck added a commit to stelcheck/mage-console that referenced this issue Dec 6, 2017
Fixes multiple outstanding issues, and pretifies error output by:

  1. using pretty-error to render the error
  2. stripping part of the stack that really should have no relevance

Fixes mage#4 mage#5 mage#8 mage#9 mage#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants