Consul improvements #278
Merged
Consul improvements #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Evertras
commented
May 17, 2019
Evertras
commented
- Instead of the PID, use the generated ID for the service so that a crash/restart will reuse the same key instead of creating dupes that will drop off and destroy our sanity as they bring down modules
- Increase rate of Consul session refreshes to half of TTL to ensure they remain alive even with latency spikes
- Don't lock on sessions so a replacement cluster can take over the key safely
stelcheck
requested changes
May 17, 2019
| if (err) { | ||
| return cb(err); | ||
| } | ||
|
|
||
| const key = [this.path, os.hostname(), process.pid].join('/'); | ||
| const key = [this.path, os.hostname(), helpers.generateId(port)].join('/'); |
There was a problem hiding this comment.
Should we remove the hostname? In dockerized environment, the hostname will be the container ID, and a new container will have a different ID but might have the same generated ID.
There was a problem hiding this comment.
That's a good point. I'll switch it to this.path, helpers.generateId instead.
…ease rate of TTL renews for Consul sessions
stelcheck
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.