Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sh.run(): quoted strings before join #306

Merged
merged 7 commits into from Dec 14, 2021
Merged

sh.run(): quoted strings before join #306

merged 7 commits into from Dec 14, 2021

Conversation

shouldsee
Copy link
Contributor

@shouldsee shouldsee commented May 12, 2020 •
edited

Unquoted string may contain whitespace,
after Joining those strings, the result cannot be split back to recover the original call.

ret:= sh.RunWith(nil, "go", "build", "-ldflags", "-X /common/hugo.commitHash= -X /common/hugo.buildDate=", "hugo")

see #304

natefinch
natefinch requested changes May 19, 2020
View reviewed changes
Copy link
Member

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after changes

sh/cmd.go Outdated Show resolved Hide resolved
sh/cmd.go Outdated Show resolved Hide resolved
sh/cmd.go Outdated Show resolved Hide resolved
shouldsee and others added 3 commits May 20, 2020 12:48
@shouldsee @natefinch
Update sh/cmd.go
b89230d 
Co-authored-by: Nate Finch <nate.finch@gmail.com>
@shouldsee @natefinch
Update sh/cmd.go
e672dba 
Co-authored-by: Nate Finch <nate.finch@gmail.com>
@shouldsee @natefinch
Use %q instead of literal quotes
2b62f93 
Co-authored-by: Nate Finch <nate.finch@gmail.com>
@shouldsee shouldsee requested a review from natefinch May 25, 2020 02:29
natefinch
natefinch previously approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tweaking to gofmt standards

sh/cmd.go Outdated Show resolved Hide resolved
@natefinch natefinch merged commit 404c119 into magefile:master Dec 14, 2021
@viktorvoltaire viktorvoltaire mentioned this pull request Dec 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natefinch natefinch natefinch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shouldsee @natefinch