Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sh.run(): quoted strings before join #306

Merged
merged 7 commits into from Dec 14, 2021
Merged

sh.run(): quoted strings before join #306

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
03778bf
sh.run(): quoted strings before join
shouldsee May 12, 2020
b89230d
Update sh/cmd.go
shouldsee May 20, 2020
e672dba
Update sh/cmd.go
shouldsee May 20, 2020
2b62f93
Use %q instead of literal quotes
shouldsee May 20, 2020
7194748
Update sh/cmd.go
natefinch Aug 12, 2020
b1feab4
Merge branch 'master' into master
natefinch Aug 12, 2020
7198738
Merge branch 'master' into master
natefinch Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions sh/cmd.go
View file
Open in desktop
Expand Up @@ -132,11 +132,14 @@ func run(env map[string]string, stdout, stderr io.Writer, cmd string, args ...st
c.Stderr = stderr
c.Stdout = stdout
c.Stdin = os.Stdin
log.Println("exec:", cmd, strings.Join(args, " "))

var quoted []string; for i:=0; i<len(args); i++ {
shouldsee marked this conversation as resolved.
Show resolved Hide resolved
quoted=append(quoted,fmt.Sprintf("\"%s\"",args[i]));
shouldsee marked this conversation as resolved.
Show resolved Hide resolved
}
log.Println("[magefile-exec]:", cmd, strings.Join(quoted, " "))
shouldsee marked this conversation as resolved.
Show resolved Hide resolved
err = c.Run()
return CmdRan(err), ExitStatus(err), err
}

// CmdRan examines the error to determine if it was generated as a result of a
// command running via os/exec.Command. If the error is nil, or the command ran
// (even if it exited with a non-zero exit code), CmdRan reports true. If the
Expand Down