Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with ETB triggers #11052

Closed
Mercsetronics opened this issue Aug 28, 2023 · 26 comments
Closed

Issue with ETB triggers #11052

Mercsetronics opened this issue Aug 28, 2023 · 26 comments
Labels
support Questions from users, help and support

Comments

@Mercsetronics
Copy link

Dear Team!

Since the last update, 9 out of 10 times, whenever I cast a creature with its evoke cost, the window "choose which triggered ability goes on the stack first" does not appear.
If I try to relaunch the client, without disconnecting, I can rejoin my game, the window appears, but there are not abilities (or anything) in the window.
I cannot click anywere, I cannot text, cannot change window, forcing me to quit the match.

Previously I barely had any quit games, now I have doubled it due to this issue, as well as lost 100 places in rankings :(

I have tried to update Java, force update the client, but nothing seems to be working,

If you could propose me a solution, I would be greatful.

Thank you for your time!

@xenohedron
Copy link
Contributor

xenohedron commented Aug 28, 2023

Sounds like #8851- a general bug that occurs when choosing an order for multiple triggers. It's real annoying, hard to reproduce consistently but still breaks games every so often. Hasn't yet been investigated and I'm not sure really where to start. I doubt it is specific to recent update though.

As a potential workaround, reconnecting (new client without closing old one) fixes sometimes, but might take multiple attempts and no guarantees.

@Mercsetronics
Copy link
Author

Thank you for your response.
I have tried your workaround (7 times at one point) with no success

@JayDi85
Copy link
Member

JayDi85 commented Aug 28, 2023

There are possible bugs with player's priority lost on broken continues/replacement effect. Maybe /fix command in the chat can help, but it useless in most use cases.

Game engine support only one choose dialog per player. If some broken effect try to ask a player in the middle of game cycle then it will broke original dialog. Examples:

  • continues or cost reduction effect try to call choose dialog on apply method;
  • another effect try to call choose dialog in applies or canActivate method instead apply;

So try to find another active/buggy card. It's can be a real reason.

@Mercsetronics
Copy link
Author

When this occurs I cannot use the chat or click anywhere in fact.
Seems like the issue happens 100% when I cast Fury with evoke, 90% when I cast Grief with evoke.
The issue just happened again, I tried the cold restart of client about 12 times, but does not resolves the issue.

@Mercsetronics
Copy link
Author

Now the issue happened with Kroxa as well.

@Susucre
Copy link
Contributor

Susucre commented Aug 29, 2023

Is that all in the same deck?
Can you link it, there might be a card inside that makes the issue reproducible.

@Mercsetronics
Copy link
Author

How can I link my deck on Xmage here?

@Susucre
Copy link
Contributor

Susucre commented Aug 29, 2023

Just paste or drag on drop the .dck file. github takes care of upload and linking it.

@Mercsetronics
Copy link
Author

For some reason it does not allow me, it says it is unsupported.

Also, same happened to a player: "11:45: Ogoun Badagris: Rich: sorry... game was asking me to choose order to stack triggered abilities, but it completely froze up the client. I couldn't do anything, couldn't even type a response"

@Mercsetronics
Copy link
Author

3 [ARB:46] Terminate
3 [ONE:248] Blackcleave Cliffs
4 [RNA:245] Blood Crypt
2 [THS:107] Thoughtseize
2 [KTK:239] Polluted Delta
4 [KTK:230] Bloodstained Mire
4 [MH2:397] Dauthi Voidwalker
4 [MH2:311] Grief
4 [MH2:126] Fury
3 [AFR:103] Feign Death
3 [VOW:134] Undying Malice
2 [SLU:1] Marsh Flats
4 [MH2:138] Ragavan, Nimble Pilferer
1 [UNF:238] Mountain
2 [UNF:237] Swamp
1 [AFR:258] Hive of the Eye Tyrant
4 [NEO:141] Fable of the Mirror-Breaker
4 [LTR:103] Orcish Bowmasters
2 [USG:132] Duress
2 [HA5:20] Kolaghan's Command
2 [3ED:162] Lightning Bolt
1 [THB:221] Kroxa, Titan of Death's Hunger
SB: 2 [5DN:118] Engineered Explosives
SB: 2 [NEO:221] Hidetsugu Consumes All
SB: 2 [2X2:94] Surgical Extraction
SB: 1 [VOW:124] Path of Peril
SB: 2 [TSR:326] Leyline of the Void
SB: 1 [BRO:128] Brotherhood's End
SB: 2 [MH2:102] Tourach, Dread Cantor
SB: 1 [DMU:331] Sheoldred, the Apocalypse
SB: 2 [9ED:176] Blood Moon

@Mercsetronics
Copy link
Author

From the list, the issue appeared with Kroxa, Grief and Fury

@Susucre
Copy link
Contributor

Susucre commented Aug 29, 2023

So I could not reproduce, cast all three around 10 times with no problem.
This might be a network code issue or a server under heavy charge issue, that I am not able to replicate locally.

@Mercsetronics
Copy link
Author

That is unfortunate. If that helps, I have never faced this issue before, only since I have updated to the current version

@JayDi85 JayDi85 added the support Questions from users, help and support label Aug 29, 2023
@JayDi85
Copy link
Member

JayDi85 commented Aug 29, 2023

@Mercsetronics as a last chance -- you can reset xmage settings to default by delete all values in HKEY_CURRENT_USER\Software\JavaSoft\Prefs\mage\client (see here for example). But be careful -- you will lost all changed hot keys, new game settings, saved password, images paths, etc.

@Mercsetronics
Copy link
Author

I tried @JayDi85 recommendation, but the problem still persist, even though a bit less frequently

@Mercsetronics
Copy link
Author

Tried deleting and reinstalling the whole thing, first game and it still does not work

@Mercsetronics
Copy link
Author

After the update, it still does not work

@Mercsetronics
Copy link
Author

Tried a clean install once again, removing that value from regedit, but still does not work

@Mercsetronics
Copy link
Author

Is there a way to reposition the window somehow, once it is supposed to appear?

@JayDi85
Copy link
Member

JayDi85 commented Sep 5, 2023

@Mercsetronics did you member when it all starting? Is it works fine before August 25?

@xenohedron
Copy link
Contributor

Over the past week or so, there's definitely been an uptick in reports (on Discord) of game getting stuck when asking to order triggers. It still sounds like #8851, and I know we experienced it a few times back in July and earlier (specifically on Patagia Viper at least twice). I am not sure what recent adjustment could have increased the frequency of this issue. Seems like it happens with quite a few different cards/effects.

@Mercsetronics
Copy link
Author

@JayDi85 prior to the release 2 weeks ago, it was working fine. Then around the 27 of August, after the update it stopped working.

@JayDi85
Copy link
Member

JayDi85 commented Sep 18, 2023

@Mercsetronics if you catch that bug then collapse and expand app's window (change window size) to call game update -- it will show choose triggers dialog again.

@Mercsetronics
Copy link
Author

@JayDi85 I tried what you have mentioned, it fixes the freeze, but the dialog window does not appear still

@Mercsetronics
Copy link
Author

I tried again the above, the window appears if I click on any cards in my hand, thank you!!

@JayDi85
Copy link
Member

JayDi85 commented Sep 21, 2023

fixed by #11189

@JayDi85 JayDi85 closed this as completed Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support Questions from users, help and support
Projects
None yet
Development

No branches or pull requests

4 participants