Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 9: NoSuchMethodException waiting for player response in duel #11856

Open
phughk opened this issue Feb 24, 2024 · 1 comment
Open

Java 9: NoSuchMethodException waiting for player response in duel #11856

phughk opened this issue Feb 24, 2024 · 1 comment

Comments

@phughk
Copy link
Contributor

phughk commented Feb 24, 2024

When compiling server and client, and then launching server and client using OpenJDK Java 9.0.4, and starting a 2 player game against a madbot, the following error occurs in the logs

java.lang.NoSuchMethodException: java.lang.Throwable.getStackTraceElement(int)
        at java.base/java.lang.Class.getDeclaredMethod(Class.java:2432)
        at mage.util.TraceHelper.<clinit>(DebugUtil.java:55)
        at mage.util.DebugUtil.getMethodNameWithSource(DebugUtil.java:40)
        at mage.player.human.HumanPlayer.waitForResponse(HumanPlayer.java:315)
        at mage.player.human.HumanPlayer.chooseMulligan(HumanPlayer.java:386)
        at mage.game.mulligan.Mulligan.executeMulliganPhase(Mulligan.java:55)
        at mage.game.mulligan.LondonMulligan.executeMulliganPhase(LondonMulligan.java:54)
        at mage.game.GameImpl.init(GameImpl.java:1286)
        at mage.game.TwoPlayerDuel.init(TwoPlayerDuel.java:35)
        at mage.game.GameImpl.start(GameImpl.java:989)
        at mage.server.game.GameWorker.call(GameWorker.java:34)
        at mage.server.game.GameWorker.call(GameWorker.java:15)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
        at java.base/java.lang.Thread.run(Thread.java:844)
java.lang.NullPointerException
        at mage.util.TraceHelper.getMethodNameWithSource(DebugUtil.java:74)
        at mage.util.DebugUtil.getMethodNameWithSource(DebugUtil.java:40)
        at mage.player.human.HumanPlayer.waitForResponse(HumanPlayer.java:315)
        at mage.player.human.HumanPlayer.chooseMulligan(HumanPlayer.java:386)
        at mage.game.mulligan.Mulligan.executeMulliganPhase(Mulligan.java:55)
        at mage.game.mulligan.LondonMulligan.executeMulliganPhase(LondonMulligan.java:54)
        at mage.game.GameImpl.init(GameImpl.java:1286)
        at mage.game.TwoPlayerDuel.init(TwoPlayerDuel.java:35)
        at mage.game.GameImpl.start(GameImpl.java:989)
        at mage.server.game.GameWorker.call(GameWorker.java:34)
        at mage.server.game.GameWorker.call(GameWorker.java:15)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
        at java.base/java.lang.Thread.run(Thread.java:844)

This ticket is related to #6197

@JayDi85
Copy link
Member

JayDi85 commented Feb 24, 2024

Real reason: java 9+ replaced getStackTraceElement with new class StackWalker, so current debug tool fail to find source code method to print in log.

It’s not a critical code so DebugUtil.java can be fixed by error ignoring and returning text like “unsupport in java 9+”. After full java 17 migration it can be returned.

IMG_9763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants